Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronize build-requirements.txt following setuptools bump #2136

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

legoktm
Copy link
Member

@legoktm legoktm commented Jul 22, 2024

Status

Work in progress; pending freedomofpress/securedrop-builder#501

Description

Update wheel checksums to match freedomofpress/securedrop-builder#501.

Test Plan

  • CI passes

Checklist

If these changes modify code paths involving cryptography, the opening of files in VMs or network (via the RPC service) traffic, Qubes testing in the staging environment is required. For fine tuning of the graphical user interface, testing in any environment in Qubes is required. Please check as applicable:

  • I have tested these changes in the appropriate Qubes environment
  • I do not have an appropriate Qubes OS workstation set up (the reviewer will need to test these changes)
  • These changes should not need testing in Qubes

If these changes add or remove files other than client code, the AppArmor profile may need to be updated. Please check as applicable:

  • I have updated the AppArmor profile
  • No update to the AppArmor profile is required for these changes
  • I don't know and would appreciate guidance

If these changes modify the database schema, you should include a database migration. Please check as applicable:

  • I have written a migration and upgraded a test database based on main and confirmed that the migration is self-contained and applies cleanly
  • I have written a migration but have not upgraded a test database based on main and would like the reviewer to do so
  • I need help writing a database migration
  • No database schema changes are needed

@legoktm legoktm added this to the 0.13.0 milestone Aug 12, 2024
@legoktm
Copy link
Member Author

legoktm commented Aug 12, 2024

This is not part of any requested 0.13.0 features, but we need to land it before the next release.

@cfm cfm self-assigned this Aug 14, 2024
@cfm cfm marked this pull request as ready for review August 14, 2024 18:41
@cfm cfm requested a review from a team as a code owner August 14, 2024 18:41
Copy link
Member

@cfm cfm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is happy after freedomofpress/securedrop-builder#501. Thanks, @legoktm.

@cfm cfm merged commit a553c66 into main Aug 14, 2024
62 checks passed
@cfm cfm deleted the setuptools-bump-sync branch August 14, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants